[webkit-reviews] review requested: [Bug 18991] SquirrelFish: Major codegen issue in a.b=expr, a[b]=expr : [Attachment 21150] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 14 19:06:30 PDT 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 18991: SquirrelFish: Major codegen issue in a.b=expr, a[b]=expr
http://bugs.webkit.org/show_bug.cgi?id=18991

Attachment 21150: Proposed patch
http://bugs.webkit.org/attachment.cgi?id=21150&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Here is a patch that fixes most of the issues. As far as I know, the only two
that it doesn't fix are the local case of ReadModifyResolveNode (it needs a
similar fix to AssignResolveNode), and the case of modifying arguments to a
function with no closure using f.arguments.


More information about the webkit-reviews mailing list