[webkit-reviews] review granted: [Bug 18976] REGRESSION (r26474): WebKit fails jQuery test 64 core module: text(String) subtest 1 Check escaped text (createTextNode) : [Attachment 21127] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 14 09:52:33 PDT 2008


Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 18976: REGRESSION (r26474): WebKit fails jQuery test 64 core module:
text(String) subtest 1 Check escaped text (createTextNode)
http://bugs.webkit.org/show_bug.cgi?id=18976

Attachment 21127: Patch v1
http://bugs.webkit.org/attachment.cgi?id=21127&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Putting these strings into separate functions might make the code slightly
slower unnecessarily. There's no particular reason these need to be shared
globals, and I had originally used a C-style string because I thought that
would be fast enough; widening the characters from 8-bit to 16-bit should be
fast enough. And using globals at all (not new to this patch) creates
unnecessary threading issues if we ever start tackling them the way we are in
JavaScriptCore.

But aside from that entirely-theoretical worry, looks perfect.

r=me


More information about the webkit-reviews mailing list