[webkit-reviews] review granted: [Bug 18869] SQUIRRELFISH: function toString broken after calling : [Attachment 21056] fix by keeping references to the original source

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 18869: SQUIRRELFISH: function toString broken after calling
http://bugs.webkit.org/show_bug.cgi?id=18869

Attachment 21056: fix by keeping references to the original source
http://bugs.webkit.org/attachment.cgi?id=21056&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me, although i am concerned about this approach in the long term.  As we are
no longer actually decompiling there are two side effects:
* It is no longer possible to use function.toString to "prettify" source which
makes debugging google, etc difficult (for us), and there are a number of
places i've seen on the web that reference decompilation as a way to reformat
JS.
* This renders a number of fuzzers somewhat useless.  JSFunFuzz for instance
does roundtrip checks which in general are meant to pick up times when we have
compiled code that does one thing into an incorrect form, which we now lose as
all we do is regurgitate what we were given.

That said if we start doing significant optimisations and restructuring with
the bytecode stream decopmilation may not be entirely helpful.