[webkit-reviews] review denied: [Bug 18887] WF2 Support for autofocus controls : [Attachment 20973] Initial implementation, second revision

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 9 09:24:49 PDT 2008

Adele Peterson <adele at apple.com> has denied Michelangelo De Simone
<m.des at mac.com>'s request for review:
Bug 18887: WF2 Support for autofocus controls

Attachment 20973: Initial implementation, second revision

------- Additional Comments from Adele Peterson <adele at apple.com>
This is a really good first cut, and I'm glad you posted this patch!

I have	a few things that I'd like you to change.

I think that instead of the code you have in the Document class, you can call
focus() directly from the HTMLGenericFormElement class when you parse the
attribute.  focus() will automatically handle updating the appearance style at
the right time.  You shouldn't need to explicitly call theme()->stateChanged.

If you do all that work in HTMLGenericFormElement, then you shouldn't need the
hasAutofocus method.  You can just do that check when you parse the attr.  And
you can check document->ignoreAutofocus() at that time too.

I think you're on the right track, and I'm looking forward to seeing what you
post next!

More information about the webkit-reviews mailing list