[webkit-reviews] review requested: [Bug 3402] onUnload event doesn't fire : [Attachment 21025] Initial patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 3402: onUnload event doesn't fire
http://bugs.webkit.org/show_bug.cgi?id=3402

Attachment 21025: Initial patch
http://bugs.webkit.org/attachment.cgi?id=21025&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
Just a first stab at this bug. In fact it only is meant for the third problem
in the Mondo testcase, using addEventListener to register an unload event
listener and then testing that it is called. I used the Mondo testcase to
verify that this now works using the patch, however I would like to get some
early feedback to a) get to know whether the approach is sane and b) whether
there is a need to support the 2nd and 4th variant (which are the same
problem).
*If* the approach is sane there may be some other help elements that may use
the same technique, ie. all that use setHTMLWindowEventListener should have
this third problem.
Cheers,

Rob.