[webkit-reviews] review requested: [Bug 16362] Incorrect implementation of 'ex' unit : [Attachment 21006] patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 7 22:50:01 PDT 2008

Anatoli Papirovski <apapirovski at mac.com> has asked  for review:
Bug 16362: Incorrect implementation of	'ex' unit

Attachment 21006: patch 2

------- Additional Comments from Anatoli Papirovski <apapirovski at mac.com>
Ok, as discussed I've corrected the xheight calculation not to make ex = em
which was done to fix a gmail bug that no longer exists. I've also removed the
"ex" from margin declaration on input radio and checkbox.

I didn't include any test cases, because a lot (and I mean A LOT) of test cases
need to be regenerated, pretty much anything that uses "ex", "x-height", or
radio or checkbox form elements.

Also, those Microsoft test cases are actually wrong... per the CSS spec, if the
font does not have an xHeight specified, the rendering engine should try and
compute it from an actual x, thus the xHeight for Ahem is 0.8 rather than 0.5.

More information about the webkit-reviews mailing list