[webkit-reviews] review requested: [Bug 18413] hixie test fails for CSS: sanity tests for relative keyword values of font-size : [Attachment 20996] patch 2

[bugzilla-daemon at webkit.org]

Anatoli Papirovski <apapirovski at mac.com> has asked  for review:
Bug 18413: hixie test fails for CSS: sanity tests for relative keyword values
of font-size
http://bugs.webkit.org/show_bug.cgi?id=18413

Attachment 20996: patch 2
http://bugs.webkit.org/attachment.cgi?id=20996&action=edit

------- Additional Comments from Anatoli Papirovski <apapirovski at mac.com>
Ok, this took a while, but I pretty much completely changed what it does... now
the behavior matches Firefox. If the original value is within the table or
within 0.5 of the table, then just find the next/previous value from the table,
otherwise extrapolate a value based on the position between the two closest
values. Also, now it doesn't just use ratios if medium size is outside the
range, it creates its own table and then uses that to do everything else.

I'm not a fan of how the code looks now, but I'm having hard time coming up
with anything better, so any ideas are welcome... or if it's fine the way it
is, that's fine by me.

A ton of test results need to be regenerated btw, because they use larger or
smaller keywords or use big/small html tags, but I didn't put those in the
patch.