[webkit-reviews] review granted: [Bug 18916] make_names.pl --factory needs to support custom c++ guard : [Attachment 20990] First try

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 6 19:05:22 PDT 2008

Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<julien.chaffraix at gmail.com>'s request for review:
Bug 18916: make_names.pl --factory needs to support custom c++ guard

Attachment 20990: First try

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good to me.

You can avoid checking guardFactory against "" everywhere by just inverting the
if.  I think that "" is false in perl.	If its not, then you can do the ""
check at the top, and assign guardFactory to some value which is false, like

it's OK as is, or with the further "" check cleanup.  I don't need to see the
patch again before you land.


More information about the webkit-reviews mailing list