[webkit-reviews] review granted: [Bug 4931] Unicode format characters (Cf) other than soft hyphen should be removed from JavaScript source : [Attachment 20970] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 5 10:26:19 PDT 2008


Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 4931: Unicode format characters (Cf) other than soft hyphen should be
removed from JavaScript source
http://bugs.webkit.org/show_bug.cgi?id=4931

Attachment 20970: patch
http://bugs.webkit.org/attachment.cgi?id=20970&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me. Looks like we are testing for the soft hyphen not being removed in a very
indirect way though - perhaps it would help to have a dedicated test case fir
this. Or maybe the existing test and the long comment that you added are
enough.


More information about the webkit-reviews mailing list