[webkit-reviews] review denied: [Bug 18859]
SVGRootInlineBox::buildTextChunks can do an invalid downcast
: [Attachment 20937] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 3 13:39:01 PDT 2008
Rob Buis <rwlbuis at gmail.com> has denied Jonathan Haas <myrdred at gmail.com>'s
request for review:
Bug 18859: SVGRootInlineBox::buildTextChunks can do an invalid downcast
http://bugs.webkit.org/show_bug.cgi?id=18859
Attachment 20937: patch
http://bugs.webkit.org/attachment.cgi?id=20937&action=edit
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
The general idea seems good to me. The braces in the if/else are not needed
since the blocks
are both single line.
Please include a testcase in the patch that would crash in the old situation
and work
fine with the patch.
r- because of the missing testcase.
More information about the webkit-reviews
mailing list