[webkit-reviews] review granted: [Bug 18568] background:
currentColor fails : [Attachment 20917] Incorporated cascade test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 1 19:45:06 PDT 2008
Eric Seidel <eric at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 18568: background: currentColor fails
http://bugs.webkit.org/show_bug.cgi?id=18568
Attachment 20917: Incorporated cascade test
http://bugs.webkit.org/attachment.cgi?id=20917&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Two comments:
1. This deserves a comment:
+ case CSSPropertyColor:
+ if (primitiveValue && primitiveValue->getIdent() ==
CSSValueCurrentcolor)
+ isInherit = true;
(about how the spec says to treat currentColor for the "color" property as
though it means inherit.)
2. Does getComputedStyle().color correctly return "currentColor" instead of
"currentcolor" ? Since I think in CSS3 they always refer to it in CamelCase,
even though we accept any case (it seems).
Otherwise it looks fine.
More information about the webkit-reviews
mailing list