[webkit-reviews] review requested: [Bug 15595] marker property doesn't show up correctly as "shorthand" in inspector : [Attachment 20201] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 29 11:41:38 PDT 2008


Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 15595: marker property doesn't show up correctly as "shorthand" in
inspector
http://bugs.webkit.org/show_bug.cgi?id=15595

Attachment 20201: First attempt
http://bugs.webkit.org/attachment.cgi?id=20201&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This patch makes the marker property show up much better in the Inspector.
There is some confusion on the exact marker property syntax, see:

http://lists.w3.org/Archives/Public/www-svg/2008Mar/0093.html

I think that needs to be clarified before this can go in.
As for tests, AFAIK it is impossible to test how it looks in the Inspector.
However I guess it makes sense to test getPropertyValue("marker") on
the CSSStyleDeclaration.
In the meantime, the code can be reviewed I guess.
Cheers,

Rob.


More information about the webkit-reviews mailing list