[webkit-reviews] review granted: [Bug 18208] Acid3 test 65 takes >33ms due to plugin refreshing on Windows : [Attachment 20197] Cleanup 4: Rename PluginPaths -> PluginDirectories

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 29 10:59:53 PDT 2008


mitz at webkit.org has granted Adam Roben (aroben) <aroben at apple.com>'s request
for review:
Bug 18208: Acid3 test 65 takes >33ms due to plugin refreshing on Windows
http://bugs.webkit.org/show_bug.cgi?id=18208

Attachment 20197: Cleanup 4: Rename PluginPaths -> PluginDirectories
http://bugs.webkit.org/attachment.cgi?id=20197&action=edit

------- Additional Comments from mitz at webkit.org
+	 void setPluginDirectories(const Vector<String>& paths) {
m_pluginDirectories = paths; }

You can change the name of the argument here too.

-bool PluginDatabase::isPreferredPluginPath(const String& path)
+bool PluginDatabase::isPreferredPluginDirectory(const String& path)

And here.

-static inline void addMozillaPluginPaths(Vector<String>& paths)
+static inline void addMozillaPluginDirectories(Vector<String>& paths)

And here.

-static inline void addWindowsMediaPlayerPluginPath(Vector<String>& paths)
+static inline void addWindowsMediaPlayerPluginDirectory(Vector<String>& paths)


And in several other places.

rs=me either way


More information about the webkit-reviews mailing list