[webkit-reviews] review requested: [Bug 18044] Timer Bug : [Attachment 20136] Removed uneeded fireTimersInNestedEventLoop

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 27 14:31:30 PDT 2008


Michael Emmel <mike.emmel at gmail.com> has asked	for review:
Bug 18044: Timer Bug
http://bugs.webkit.org/show_bug.cgi?id=18044

Attachment 20136: Removed uneeded fireTimersInNestedEventLoop
http://bugs.webkit.org/attachment.cgi?id=20136&action=edit

------- Additional Comments from Michael Emmel <mike.emmel at gmail.com>

This patch removes the uneeded and incorrect fireTimersInNestedEventLoop and
cleans up the Timer patch.

The reason fireTimersInNestedEventLoop is incorrect is that nesting of event
loops is done inside the GTK application WebKit cannot correctly determine if
its running in a nested event loop set up by the application using the the
WebKit widget.	So its wrong to not function correctly in nested event loops
that may be created using the platform api outside of the scope of WebKit.


More information about the webkit-reviews mailing list