[webkit-reviews] review requested: [Bug 18044] Timer Bug : [Attachment 20114] Nested event loop patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 26 19:52:09 PDT 2008
Michael Emmel <mike.emmel at gmail.com> has asked for review:
Bug 18044: Timer Bug
http://bugs.webkit.org/show_bug.cgi?id=18044
Attachment 20114: Nested event loop patch
http://bugs.webkit.org/attachment.cgi?id=20114&action=edit
------- Additional Comments from Michael Emmel <mike.emmel at gmail.com>
I looked at the log and this is really the same problem that was supposedly
fixed by <rdar://problem/5094895> REGRESSION (r19094)
I re factored the patch to make at cleaner and remove the case of someone
resetting and removing a timer from the fire list that has not yet fired. Now a
timer is only removed from the fire list right before it fires and the fire
list is not mutated out side of the shared callback.
The special
fireTimersInNestedEventLoop
is not needed anymore.
More information about the webkit-reviews
mailing list