[webkit-reviews] review granted: [Bug 17079] XML document sent with wrong encoding does not fail as expected (affects Acid3 test 70) : [Attachment 20083] Fix, makes us pass Test 70, now includes minimal testing

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 17079: XML document sent with wrong encoding does not fail as expected
(affects Acid3 test 70)
http://bugs.webkit.org/show_bug.cgi?id=17079

Attachment 20083: Fix, makes us pass Test 70, now includes minimal testing
http://bugs.webkit.org/attachment.cgi?id=20083&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
 672	 if (m_doc->decoder() && m_doc->decoder()->sawError())
 673	     // If the decoder saw an error, report it as fatal (stops parsing)

 674	     handleError(fatal, "Encoding error", lineNumber(),
columnNumber());

Needs braces. We normally put braces around multiple lines even if one is a
comment.

r=me