[webkit-reviews] review requested: [Bug 18064] assert-fail in WebCore::FrameLoader::saveDocumentState (document is null) : [Attachment 20080] remove bogus assertion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 26 03:35:59 PDT 2008


Jasper Bryant-Greene <jasper at unix.geek.nz> has asked  for review:
Bug 18064: assert-fail in WebCore::FrameLoader::saveDocumentState (document is
null)
http://bugs.webkit.org/show_bug.cgi?id=18064

Attachment 20080: remove bogus assertion
http://bugs.webkit.org/attachment.cgi?id=20080&action=edit

------- Additional Comments from Jasper Bryant-Greene <jasper at unix.geek.nz>
I'm pretty sure the ASSERT is bogus, because a frame can contain no document
under certain circumstances, and because there's an if() test immediately after
that protects against the case that the ASSERT is checking for.

Also because although the ASSERT trips on the debug build (for example when
clicking the reference rendering link on http://acid3.acidtests.org/), the
release build works fine in the same circumstances.

Thus this patch removes the ASSERT.


More information about the webkit-reviews mailing list