[webkit-reviews] review granted: [Bug 17252] Acid3 test removing Nodes during NodeIterator walk fails (affects Acid3 test 2) : [Attachment 20065] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 25 17:59:43 PDT 2008


Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 17252: Acid3 test removing Nodes during NodeIterator walk fails (affects
Acid3 test 2)
http://bugs.webkit.org/show_bug.cgi?id=17252

Attachment 20065: patch
http://bugs.webkit.org/attachment.cgi?id=20065&action=edit

------- Additional Comments from Anders Carlsson <andersca at apple.com>

>Index: LayoutTests/traversal/resources/acid3-test-2.js
>===================================================================
>--- LayoutTests/traversal/resources/acid3-test-2.js	(revision 0)
>+++ LayoutTests/traversal/resources/acid3-test-2.js	(revision 0)
>@@ -0,0 +1,73 @@
>+description("Test of behavior NodeIterator when nodes are removed, from
Acid3.");
>+
>+    var iframe = document.createElement("iframe");
>+    iframe.setAttribute("src", "about:blank");
>+    document.body.appendChild(iframe);
>+    var doc = iframe.contentDocument;
>+    for (var i = doc.documentElement.childNodes.length-1; i >= 0; i -= 1)
>+	doc.documentElement.removeChild(doc.documentElement.childNodes[i]);
>+    doc.documentElement.appendChild(doc.createElement('head'));
>+    doc.documentElement.firstChild.appendChild(doc.createElement('title'));
>+    doc.documentElement.appendChild(doc.createElement('body'));
>+

Indentation looks weird here.

r=me


More information about the webkit-reviews mailing list