[webkit-reviews] review denied: [Bug 6503] content property doesn't support quotes : [Attachment 20006] first patch (almost finished) for 'content: *quotes' and 'quotes' properties

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Vincent Ricard <magic at magicninja.org>'s
request for review:
Bug 6503: content property doesn't support quotes
http://bugs.webkit.org/show_bug.cgi?id=6503

Attachment 20006: first patch (almost finished) for 'content: *quotes' and
'quotes' properties
http://bugs.webkit.org/attachment.cgi?id=20006&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Nice work adding this!

The convention of _ arguments in the QuotesValue is not something we use these
days.  Also the & should be with const String& in the QuoteValue constructor.

The QuoteValue object should have m_ in front of its member variable names,
e.g., m_openQuote, m_closeQuote.

Pointer placement is wrong in the RenderQuote constructor.

Document *node

should be

Document* node

Is redoing pref widths inside dirtyLineBoxes really necessary, or did you just
copy this file from RenderCounter and accidentally pick that up?

You can't just do a raw pointer comparison in the equality operator of
StyleRareInheritedData.

&& m_quotes == o.m_quotes;

You need to actually check if the quotes objects are equivalent.

Extraneous whitespace change:

-    unsigned wordWrap : 1; // EWordWrap 
+    unsigned wordWrap : 1; // EWordWrap

In CSSStyleSelector for the case where you clear out the quotes (CSSValueNone),
can't you just set to 0 instead of to new QuotesData?