[webkit-reviews] review denied: [Bug 18044] Timer Bug : [Attachment 20007] Patch for silently failing timers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 24 22:35:12 PDT 2008


Brady Eidson <beidson at apple.com> has denied Michael Emmel
<mike.emmel at gmail.com>'s request for review:
Bug 18044: Timer Bug
http://bugs.webkit.org/show_bug.cgi?id=18044

Attachment 20007: Patch for silently failing timers
http://bugs.webkit.org/attachment.cgi?id=20007&action=edit

------- Additional Comments from Brady Eidson <beidson at apple.com>
At a high level, I don't feel qualified to really review this patch - there are
a few folks who are intimately familiar with the timer code who would be much
safer reviewers.

But, I can still make a review decision based on:
1 - Can you provide an example of how this bug is manifesting itself?
2 - Using that real world example/reduction, can a layout test be made?
3 - A Changelog entry is also required


More information about the webkit-reviews mailing list