[webkit-reviews] review granted: [Bug 18046] SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs : [Attachment 20013] handle multichar glyph metrics and rendering correctly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 24 16:57:51 PDT 2008


Eric Seidel <eric at webkit.org> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 18046: SVGTextElement.getStartPositionOfChar does not correctly account for
multichar glyphs
http://bugs.webkit.org/show_bug.cgi?id=18046

Attachment 20013: handle multichar glyph metrics and rendering correctly
http://bugs.webkit.org/attachment.cgi?id=20013&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Aside from my two corrections above, the patch looks sane.  extraCharsAvailable
could be part of TextRun, but you had performance concerns.  I think it's OK to
not have it part of TextRun (at least for now).


More information about the webkit-reviews mailing list