[webkit-reviews] review granted: [Bug 17685] CSS3 Selector Test: attribute selector failing to match empty string : [Attachment 19985] patch for the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 23 13:29:56 PDT 2008


Eric Seidel <eric at webkit.org> has granted Robert Blaut <webkit at blaut.biz>'s
request for review:
Bug 17685: CSS3 Selector Test: attribute selector failing to match empty string
http://bugs.webkit.org/show_bug.cgi?id=17685

Attachment 19985: patch for the bug
http://bugs.webkit.org/attachment.cgi?id=19985&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good to me.  I'll fix the comment when landing.

// The selector's value can't contain a space, neither can be empty, or it's
totally bogus.

should be:

// Empty selectors or selectors containing spaces are bogus.


More information about the webkit-reviews mailing list