[webkit-reviews] review requested: [Bug 3580] iFrames Appear to be Cached : [Attachment 19966] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 22 02:34:19 PDT 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 3580: iFrames Appear to be Cached
http://bugs.webkit.org/show_bug.cgi?id=3580

Attachment 19966: Proposed patch
http://bugs.webkit.org/attachment.cgi?id=19966&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Here is a patch that fixes this bug. The problem is that when a WebFrame was
loading a URL into a child, there were certain conditions under which it would
take the URL from a history item (such as back/forward navigation), and one of
these conditions was when it was a reload. This is always incorrect behaviour,
at least as far as I can tell.

This patch also fixes bug 15554 and bug 15486.

I am not quite sure how to make a test for this. Perhaps script an HTTP test?
It might be more effort than it is worth for now.


More information about the webkit-reviews mailing list