[webkit-reviews] review requested: [Bug 17967] image ALT text not shown when image loading is disabled : [Attachment 19898] Proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 20 07:20:30 PDT 2008


Alan Jenkins <alan-jenkins at tuffmail.co.uk> has asked  for review:
Bug 17967: image ALT text not shown when image loading is disabled
http://bugs.webkit.org/show_bug.cgi?id=17967

Attachment 19898: Proposed fix
http://bugs.webkit.org/attachment.cgi?id=19898&action=edit

------- Additional Comments from Alan Jenkins <alan-jenkins at tuffmail.co.uk>
Regression tests aren't running under linux :-(.  I've tried to follow the rest
of the code submission guidelines though.

Build and run-tested, on linux Qt and Gtk.  Does more or less what it's
supposed to.  It's not ideal - Firefox has a better solution, where it almost
looks like the ALT text is made into a text node and completely replaces the
image.	In particular, the ALT text for inline images will not have the same
baseline as the surrounding text.  It's much better than doing nothing though.


More information about the webkit-reviews mailing list