[webkit-reviews] review denied: [Bug 15415] parse the end of line about the FTPDIR list error! : [Attachment 19859] fix ftpdir
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 18 09:52:01 PDT 2008
Brady Eidson <beidson at apple.com> has denied wesleyZeng
<weihong.zeng at hotmail.com>'s request for review:
Bug 15415: parse the end of line about the FTPDIR list error!
http://bugs.webkit.org/show_bug.cgi?id=15415
Attachment 19859: fix ftpdir
http://bugs.webkit.org/attachment.cgi?id=19859&action=edit
------- Additional Comments from Brady Eidson <beidson at apple.com>
This was a good find, but I think the fix is wrong for this reason:
We treat any of the sequences - /r, /r/n, and /n - as newlines. foundNewLine
should be set whenever we encounter *any* of these sequences. I think moving
the foundNewLine assignment isn't right, but adding the new one is (so we have
it in both places)
More information about the webkit-reviews
mailing list