[webkit-reviews] review granted: [Bug 17679] Shared PluginView implementation : [Attachment 19856] Updated patch to refactor PluginView

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 17679: Shared PluginView implementation
http://bugs.webkit.org/show_bug.cgi?id=17679

Attachment 19856: Updated patch to refactor PluginView
http://bugs.webkit.org/attachment.cgi?id=19856&action=edit

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
This looks good to me, a couple of minor things:

16	   * WebCoreSOurces.bkl:

Capital 'O'

69 void PluginView::invalidateRegion(NPRegion) {notImplemented(); }

Missing a space.

Should combine the private members in PluginView.h that are wrapped in #if
PLATFORM(WIN).

Looks like you're missing PluginMessageThrottlerWin.{h,cpp}.

r=me if you add the missing files, and thanks!