[webkit-reviews] review requested: [Bug 17679] Shared PluginView implementation : [Attachment 19856] Updated patch to refactor PluginView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 17 17:21:13 PDT 2008


Rodney Dawes <dobey at wayofthemonkey.com> has asked  for review:
Bug 17679: Shared PluginView implementation
http://bugs.webkit.org/show_bug.cgi?id=17679

Attachment 19856: Updated patch to refactor PluginView
http://bugs.webkit.org/attachment.cgi?id=19856&action=edit

------- Additional Comments from Rodney Dawes <dobey at wayofthemonkey.com>
Here is an updated smaller patch which implements a shared PluginView class.
This version avoids using #if PLATFORM(WIN) in the cross-platform code, and
just migrates the bare minimum for now, until other refactoring can be done
with Widget as well. This will allow platforms to implement working plug-in
support for their ports. It would be great if we could get this in asap, as I
will be submitting refactored portions of my GTK+ plug-in support patch based
on this refactoring, tomorrow. :)


More information about the webkit-reviews mailing list