[webkit-reviews] review denied: [Bug 15263] REGRESSION: scrolldelay=0 causes marquee not to display : [Attachment 19812] Patch to make marquee elements handle empty strings in the truespeed attribute correctly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 17 11:07:47 PDT 2008


Darin Adler <darin at apple.com> has denied Aaron Golden <aegolden at gmail.com>'s
request for review:
Bug 15263: REGRESSION: scrolldelay=0 causes marquee not to display
http://bugs.webkit.org/show_bug.cgi?id=15263

Attachment 19812: Patch to make marquee elements handle empty strings in the
truespeed attribute correctly
http://bugs.webkit.org/attachment.cgi?id=19812&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for contributing this fix. Looks great!

This patch has tab characters in it. We can't land it like that, so please make
a patch that does not have it.

+	 * ChangeLog:

The ChangeLog itself should not be listed in the change log.

+	 * WebCore.xcodeproj/project.pbxproj:

The project file should not be listed in the change log.

The patch needs to include a test case in the LayoutTests directory. We require
a test case for each bug we fix. It should be relatively straightforward to
convert the tests attached to this bug into a layout test.

review- because of the lack of tests


More information about the webkit-reviews mailing list