[webkit-reviews] review granted: [Bug 17760] <img> treats empty src as no image at all : [Attachment 19832] A new patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 17 07:47:53 PDT 2008


Darin Adler <darin at apple.com> has granted Yuzhu Shen <yuzhu.shen at gmail.com>'s
request for review:
Bug 17760: <img> treats empty src as no image at all
http://bugs.webkit.org/show_bug.cgi?id=17760

Attachment 19832: A new patch.
http://bugs.webkit.org/attachment.cgi?id=19832&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'm pretty sure that instead of this patch you could have just changed the
attr.isEmpty() to attr.isNull(); there's no reason to rearrange the code like
this. I don't see any reason to not run the "load manually" case with an empty
URL too.

But this is OK. r=me


More information about the webkit-reviews mailing list