[webkit-reviews] review denied: [Bug 17696] form tag causing
misalignment in footer : [Attachment 19697] patch for setting
margin-bottom in quirk mode only
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 16 15:07:13 PDT 2008
Darin Adler <darin at apple.com> has denied 's request for review:
Bug 17696: form tag causing misalignment in footer
http://bugs.webkit.org/show_bug.cgi?id=17696
Attachment 19697: patch for setting margin-bottom in quirk mode only
http://bugs.webkit.org/attachment.cgi?id=19697&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
When I applied this patch and ran regression tests to prepare to check in, 8
regression tests failed:
fast/block/margin-collapse/103.html
fast/frames/viewsource-empty-attribute-value.html
tables/mozilla/bugs/bug44505.html
tables/mozilla/bugs/bug51727.html
tables/mozilla/bugs/bug52505.html
tables/mozilla/bugs/bug52506.html
tables/mozilla_expected_failures/bugs/bug2479-2.html
tables/mozilla_expected_failures/bugs/bug56024.html
We'll need a new version of this patch that includes changes to the expected
results for tests that we expect to change. Marking this review- until then.
More information about the webkit-reviews
mailing list