[webkit-reviews] review denied: [Bug 17851] Should be able to build WebCore without prefix header injection : [Attachment 19766] Include headers and provide forward declarations as needed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 14 13:15:04 PDT 2008


Darin Adler <darin at apple.com> has denied Mark Mentovai <mark at moxienet.com>'s
request for review:
Bug 17851: Should be able to build WebCore without prefix header injection
http://bugs.webkit.org/show_bug.cgi?id=17851

Attachment 19766: Include headers and provide forward declarations as needed
http://bugs.webkit.org/attachment.cgi?id=19766&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This is not a good change. There's no practical way to keep all these things
compiling without a prefix header, and no real benefit either.

I've been moving the code in the opposite direction, removing includes added
for only theoretical reasons.

Is there any real world advantage to this?


More information about the webkit-reviews mailing list