[webkit-reviews] review denied: [Bug 17807] CSSPropertyNames.h should be generated as C source : [Attachment 19711] Use "typedef enum" in makeprop.pl, which generates CSSPropertyNames.{h, c}
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 12 14:24:55 PDT 2008
Darin Adler <darin at apple.com> has denied Mark Mentovai <mark at moxienet.com>'s
request for review:
Bug 17807: CSSPropertyNames.h should be generated as C source
http://bugs.webkit.org/show_bug.cgi?id=17807
Attachment 19711: Use "typedef enum" in makeprop.pl, which generates
CSSPropertyNames.{h,c}
http://bugs.webkit.org/attachment.cgi?id=19711&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
This patch isn't really a good idea. Instead the generated file should be
changed to CSSPropertyNames.cpp. We have no reason to use C instead of C++ for
part of WebKit.
More information about the webkit-reviews
mailing list