[webkit-reviews] review granted: [Bug 17783] Correct USE macros from CF to CFNETWORK : [Attachment 19681] Patch to conditionalize based on CFNetwork
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 11 16:10:35 PDT 2008
Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at gmail.com>'s request for review:
Bug 17783: Correct USE macros from CF to CFNETWORK
http://bugs.webkit.org/show_bug.cgi?id=17783
Attachment 19681: Patch to conditionalize based on CFNetwork
http://bugs.webkit.org/attachment.cgi?id=19681&action=edit
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
You should add a summary of the changes to the ChangeLog. Something like
"Compilation fixes when using CoreFoundation but not CFNetwork".
r=me, though the ResourceHandle.h change seems out of place in this patch.
More information about the webkit-reviews
mailing list