[webkit-reviews] review denied: [Bug 17760] <img> treats empty src as no image at all : [Attachment 19657] The patch for this bug.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 11 07:46:01 PDT 2008


Darin Adler <darin at apple.com> has denied Yuzhu Shen <yuzhu.shen at gmail.com>'s
request for review:
Bug 17760: <img> treats empty src as no image at all
http://bugs.webkit.org/show_bug.cgi?id=17760

Attachment 19657: The patch for this bug.
http://bugs.webkit.org/attachment.cgi?id=19657&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This patch treats src="" the same as no src attribute at all. And the test case
doesn't check for that. I think this is wrong.

To distinguish the case with no attribute at all, you should check the src
value for attr.isNull().


More information about the webkit-reviews mailing list