[webkit-reviews] review granted: [Bug 17640] eliminate WebCoreFrameBridge : [Attachment 19610] patch that moves keyboard mode off the bridge

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 10 08:49:36 PDT 2008


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 17640: eliminate WebCoreFrameBridge
http://bugs.webkit.org/show_bug.cgi?id=17640

Attachment 19610: patch that moves keyboard mode off the bridge
http://bugs.webkit.org/attachment.cgi?id=19610&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
I am not too crazy about having ChromeClient implementations in ChromeMac.mm,
but I assume it is to get around having to implement it for the
SVGImageEmptyClient.  If that is the case, we should have a new file, perhaps
ChromeClientMac.mm, to contain these base implementations.

Could you also explain in the changelog why it is okay to remove 
-    ASSERT_MAIN_THREAD();
from the finalize method of WebFrameBridge.

r=me


More information about the webkit-reviews mailing list