[webkit-reviews] review requested: [Bug 15229] [gtk] abstract font management by using pango : [Attachment 19631] Pango font backend.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 10 07:02:58 PDT 2008


Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 15229: [gtk] abstract font management by using pango
http://bugs.webkit.org/show_bug.cgi?id=15229

Attachment 19631: Pango font backend.
http://bugs.webkit.org/attachment.cgi?id=19631&action=edit

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Took Herzi's patch and massaged it into a new optional font backend as
discussed with alp. The existing backend is called the 'freetype' backend,
although the files are still suffixed with Gtk.

I've done two code changes:
- Use pango_cairo_font_map_get_default to create the font map instead of
pango_cairo_font_map_new.
- Free the hash table in the destructor.

The custom font stuff is unimplemented in the pango backend.


More information about the webkit-reviews mailing list