[webkit-reviews] review granted: [Bug 17261] IconRecord::loadImageFromResource is not called from WebCore : [Attachment 19513] Allow to use an external urlIcon

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Holger Freyther
<freyther at handhelds.org>'s request for review:
Bug 17261: IconRecord::loadImageFromResource is not called from WebCore
http://bugs.webkit.org/show_bug.cgi?id=17261

Attachment 19513: Allow to use an external urlIcon
http://bugs.webkit.org/attachment.cgi?id=19513&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

The code seems fine.

There's no ChangeLog here. The comment in the email seems less good. The
mention of "closed" vs. "open" and "forcing a specific icon onto the user"
seems wrong.

The real issue is simply which platforms have a themeable URL icon that we want
to use. We chose not to do that on Mac OS X or Windows, and but we'd like to do
it for Qt and maybe later for GTK. That's all quite sensible, but as far as I
can tell this has nothing to do with closed vs. open or forcing anyone to do
anything.