[webkit-reviews] review denied: [Bug 17675] Split WebCore.vcproj into Generic and CG-specific projects : [Attachment 19552] Revision 2 based on arboen's comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 5 14:44:51 PST 2008
Adam Roben (aroben) <aroben at apple.com> has denied Brent Fulgham
<bfulgham at gmail.com>'s request for review:
Bug 17675: Split WebCore.vcproj into Generic and CG-specific projects
http://bugs.webkit.org/show_bug.cgi?id=17675
Attachment 19552: Revision 2 based on arboen's comments
http://bugs.webkit.org/attachment.cgi?id=19552&action=edit
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
I think we should put webcore.vsprops right next to WebCore.vcproj instead of
beneath $WebKitLibrariesDir, since it's not being shared between projects
outside of WebCore.
I think we should add WinLauncher to the solution in a separate patch.
Other than that, looks good!
More information about the webkit-reviews
mailing list