[webkit-reviews] review granted: [Bug 17640] eliminate WebCoreFrameBridge : [Attachment 19525] patch for runOpenPanel
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 5 10:22:53 PST 2008
Adam Roben (aroben) <aroben at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 17640: eliminate WebCoreFrameBridge
http://bugs.webkit.org/show_bug.cgi?id=17640
Attachment 19525: patch for runOpenPanel
http://bugs.webkit.org/attachment.cgi?id=19525&action=edit
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+void ChromeClient::runOpenPanel(PassRefPtr<FileChooser>)
+{
+}
Why is this empty implementation needed in ChromeMac.mm? Can't you make this
method declaration pure virtual and just have WebChromeClient implement it?
r=me regardless
More information about the webkit-reviews
mailing list