[webkit-reviews] review requested: [Bug 17017] Remove KJS::UChar : [Attachment 19535] Updated combined patch for removing KJS::UChar

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 4 16:56:00 PST 2008


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 17017: Remove KJS::UChar
http://bugs.webkit.org/show_bug.cgi?id=17017

Attachment 19535: Updated combined patch for removing KJS::UChar
http://bugs.webkit.org/attachment.cgi?id=19535&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 JavaScriptCore/API/JSStringRef.cpp		    |	 8 +-
 JavaScriptCore/API/JSStringRefCF.cpp		    |	 2 +-
 JavaScriptCore/JavaScriptCore.exp		    |	10 ++--
 JavaScriptCore/bindings/c/c_utility.cpp	    |	 8 +-
 JavaScriptCore/bindings/objc/objc_utility.mm	    |	 2 +-
 JavaScriptCore/kjs/Parser.h			    |	 2 -
 JavaScriptCore/kjs/function.cpp		    |	34 +++++-----
 JavaScriptCore/kjs/function_object.cpp 	    |	 4 +-
 JavaScriptCore/kjs/identifier.cpp		    |	 8 +-
 JavaScriptCore/kjs/interpreter.h		    |	 4 +-
 JavaScriptCore/kjs/lexer.cpp			    |	29 ++++----
 JavaScriptCore/kjs/lookup.cpp			    |	 2 +-
 JavaScriptCore/kjs/nodes2string.cpp		    |	 5 +-
 JavaScriptCore/kjs/regexp.cpp			    |	 6 +-
 JavaScriptCore/kjs/string_object.cpp		    |	38 +++++-----
 JavaScriptCore/kjs/ustring.cpp 		    |	48 ++++++------
 JavaScriptCore/kjs/ustring.h			    |	74 ++-----------------
 JavaScriptCore/pcre/pcre.h			    |	 4 +-
 .../bindings/js/JSCSSStyleDeclarationCustom.cpp    |	12 ++--
 WebCore/bindings/js/JSSVGPODTypeWrapper.h	    |	 2 +-
 WebCore/bindings/js/kjs_proxy.cpp		    |	 2 +-
 WebCore/bindings/js/kjs_window.cpp		    |	 4 +-
 WebCore/dom/Document.cpp			    |	 4 +-
 WebCore/platform/text/AtomicString.cpp 	    |	 4 +-
 WebCore/platform/text/String.cpp		    |	 8 +-
 WebCore/platform/text/TextCodecICU.cpp 	    |	 2 +-
 WebCore/svg/SVGAnimatedTemplate.h		    |	 2 +-
 27 files changed, 135 insertions(+), 193 deletions(-)


More information about the webkit-reviews mailing list