[webkit-reviews] review denied: [Bug 13031] [Mac] onkeydown prevents keyboard shortcuts from working on this page when the input field had focus. : [Attachment 19411] First attempt (fix + manual test)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 3 06:35:51 PST 2008


Alexey Proskuryakov <ap at webkit.org> has denied Julien Chaffraix
<julien.chaffraix at gmail.com>'s request for review:
Bug 13031: [Mac] onkeydown prevents keyboard shortcuts from working on this
page when the input field had focus.
http://bugs.webkit.org/show_bug.cgi?id=13031

Attachment 19411: First attempt (fix + manual test)
http://bugs.webkit.org/attachment.cgi?id=19411&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I think that handling the key and reporting that it was not handled is OK, but
it needs to be more fine-grained. Sites need to be able to override most
command-key equivalents - if anything, they want more complete control than
they have now.

As far as keyboard event handling goes, we aim to match IE more closely than
Firefox. In IE, most Control-key shortcuts are blocked on this test page.

In addition, I think that it is really an application-level decision on which
shortcuts to enforce despite site desires, so Safari needs to be changed in
parallel. I'm not yet sure what the right way to achieve this would be.


More information about the webkit-reviews mailing list