[webkit-reviews] review denied: [Bug 17626] Programatically set background color and 16-bit alpha on WebKit GTK : [Attachment 19469] Patch to set background color and alpha

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Sean Egan <seanegan at gmail.com>'s
request for review:
Bug 17626: Programatically set background color and 16-bit alpha on WebKit GTK
http://bugs.webkit.org/show_bug.cgi?id=17626

Attachment 19469: Patch to set background color and alpha
http://bugs.webkit.org/attachment.cgi?id=19469&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 g_value_set_uint(value,
webkit_web_view_get_background_alpha(webView));
     default:

Missing a break here. I'm going to set review- because of that. Otherwise looks
pretty good, but I'm not a GTK platform expert.

-	 gboolean transparent;
+	GdkColor bg_color;
+	guint16 bg_alpha;
+	gboolean bg_color_set;

This indentation in the new code is done with tabs, and there's also a tab in
the ChangeLog entry. We can't check tabs into our repository, so please try to
avoid tabs while writing the patch to help the person committing it.