[webkit-reviews] review denied: [Bug 17634] Bug in string-validate-input SunSpider test : [Attachment 19482] string-validate-input.js patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 2 18:30:02 PST 2008


Darin Adler <darin at apple.com> has denied John Resig <jresig at mozilla.com>'s
request for review:
Bug 17634: Bug in string-validate-input SunSpider test
http://bugs.webkit.org/show_bug.cgi?id=17634

Attachment 19482: string-validate-input.js patch
http://bugs.webkit.org/attachment.cgi?id=19482&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Not a bug.

This test intentionally testing cases where variables are not declared. This
correctly reflects the sloppiness you'll see in lots of real world scripts.

Most JavaScript engines are faster if you declare the variables, but this test
is testing the slower code path.


More information about the webkit-reviews mailing list