[webkit-reviews] review requested: [Bug 16898] REGRESSION: Text of entire page incorrectly center aligned : [Attachment 19476] Fix for the problem that ignores rules with an invalid value
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 1 18:10:12 PST 2008
Kevin Ollivier <kevino at theolliviers.com> has asked for review:
Bug 16898: REGRESSION: Text of entire page incorrectly center aligned
http://bugs.webkit.org/show_bug.cgi?id=16898
Attachment 19476: Fix for the problem that ignores rules with an invalid value
http://bugs.webkit.org/attachment.cgi?id=19476&action=edit
------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
This is my first foray into CSSGrammar.y and Bison code, so I would really
appreciate some extra eyes on this fix. I'm not seeing any new layout test
failures after the change, but I don't know if there are any corner cases I'm
missing or if the approach might be overly general.
Also, I assume we want a layout test created for this, so that the regression
won't recur later on? Where should I put it? And do we need to generate results
on all platforms for it? (New to writing LayoutTests too, sorry... ;-)
More information about the webkit-reviews
mailing list