[webkit-reviews] review requested: [Bug 19821] Merge the instruction pair (less, jfalse) : [Attachment 22002] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 29 23:03:49 PDT 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 19821: Merge the instruction pair (less, jfalse)
https://bugs.webkit.org/show_bug.cgi?id=19821

Attachment 22002: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=22002&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
It turns out that the regression was entirely due to the changes in
CodeGenerator. Adding ALWAYS_INLINE to CodeGenerator::rewindBinaryOp() fixed
the regression. It is now a 2.4% progression on SunSpider.


More information about the webkit-reviews mailing list