[webkit-reviews] review denied: [Bug 19802] [GTK] Add functions to scroll the view by pixels, lines or pages : [Attachment 21989] 0001-webkit-add-functions-to-scroll-the-view-by-pixels.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 29 10:50:44 PDT 2008

Christian Dywan <christian at imendio.com> has denied Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 19802: [GTK] Add functions to scroll the view by pixels, lines or pages

Attachment 21989: 0001-webkit-add-functions-to-scroll-the-view-by-pixels.patch

------- Additional Comments from Christian Dywan <christian at imendio.com>
(In reply to comment #1)
> Created an attachment (id=21989) [edit]
> 0001-webkit-add-functions-to-scroll-the-view-by-pixels.patch

I don't see why this needs to be part of the API.

The EphyEmbed code already used the GtkAdjustment to implement this, and that's
how this should be done. In fact this is too specialized for general use. In
the linked Epiphany bug you even attempted to remove this code entirely until
you noticed that one extension appears to need this.

More information about the webkit-reviews mailing list