[webkit-reviews] review requested: [Bug 19159] Inspector should support console.time/console.timeEnd : [Attachment 21985] fixed mistakes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 28 05:20:31 PDT 2008

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 19159: Inspector should support console.time/console.timeEnd

Attachment 21985: fixed mistakes

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
Thank you Darin. I really learn a lot.

I realized I've made a few mistakes.

I forgot these
if (!m_frame)

and I realized that bug #19791 Inspector should show the source file that
called console.time and console.timeEnd
was my complete misunderstanding.
I think we can show the source files by passing
m_frame->loader()->url()->string() as sourceURL

More information about the webkit-reviews mailing list