[webkit-reviews] review granted: [Bug 19778] [Gtk] Initialize webview settings before running DRT tests : [Attachment 21946] Initialize webView settings before running test

[bugzilla-daemon at webkit.org]

Christian Dywan <christian at imendio.com> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 19778: [Gtk] Initialize webview settings before running DRT tests
https://bugs.webkit.org/show_bug.cgi?id=19778

Attachment 21946: Initialize webView settings before running test
https://bugs.webkit.org/attachment.cgi?id=21946&action=edit

------- Additional Comments from Christian Dywan <christian at imendio.com>
>+    g_object_set(G_OBJECT(settings),
>+		   "default-font-family", "Times",
>+		   "monospace-font-family", "Courier",
>+		   "serif-font-family", "Times",
>+		   "sans-serif-font-family", "Helvetica",
>+		   "default-font-size", 16,
>+		   "default-monospace-font-size", 13,
>+		   "minimum-font-size", 1,
>+		   NULL);

This looks fine to me.

> This matches some of Mac's font settings. Is there anything else I'm missing?


You might also disable the back forward list via
webkit_web_view_set_maintains_back_forward_list. According to a comment in the
mac port leaving it enabled, which is the case by default, can cause layout
bugs.