[webkit-reviews] review denied: [Bug 19762] Crash in svg/webarchive/svg-cursor-subresources.svg : [Attachment 21958] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 27 00:54:25 PDT 2008


Alexey Proskuryakov <ap at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 19762: Crash in svg/webarchive/svg-cursor-subresources.svg
https://bugs.webkit.org/show_bug.cgi?id=19762

Attachment 21958: First attempt
https://bugs.webkit.org/attachment.cgi?id=21958&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This may crash if the document happens to be destructed before the element.
Also, adding such code to all element destructors will likely affect
performance.

Maybe CSSCursorImageValue could check if the document is being destroyed, and
avoid getting by id in this case?

+	 WARNING: NO TEST CASES ADDED OR CHANGED

I do not think that we need this line in ChangeLog.


More information about the webkit-reviews mailing list