[webkit-reviews] review requested: [Bug 19130] [GTK] ChromeClient::createWindow and friends need to be implemented : [Attachment 21935] new proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 25 14:35:47 PDT 2008

Gustavo Noronha Silva <gns at gnome.org> has asked  for review:
Bug 19130: [GTK] ChromeClient::createWindow and friends need to be implemented

Attachment 21935: new proposed patch

------- Additional Comments from Gustavo Noronha Silva <gns at gnome.org>
I haven't removed/changed show-web-view yet, though it looks like we might:

 shiira implements the webViewShow delegate and does this:
     document = [[NSDocumentController sharedDocumentController] 
	     documentForWindow:[webView window]];
     [document showWindows];
 kalikiana: aha:
 kalikiana: that may answer our doubt about the delay; according to that doc,
show-web-view would be invoked directly after create-web-view
 what I find weird about the way this is documented is that their
createWebViewWithRequest needs to ask the frame to load the request, while, as
barisione showed me, webcore already loads the request on the newly created

kov: Hm.... makes me wonder how useful that signal is. I mean, if web-view-show
is emitted immediately afterwards anyway, why bother to use that?

More information about the webkit-reviews mailing list