[webkit-reviews] review requested: [Bug 19130] [GTK] ChromeClient::createWindow and friends need to be implemented : [Attachment 21935] new proposed patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha Silva <gns at gnome.org> has asked  for review:
Bug 19130: [GTK] ChromeClient::createWindow and friends need to be implemented
https://bugs.webkit.org/show_bug.cgi?id=19130

Attachment 21935: new proposed patch
https://bugs.webkit.org/attachment.cgi?id=21935&action=edit

------- Additional Comments from Gustavo Noronha Silva <gns at gnome.org>
I haven't removed/changed show-web-view yet, though it looks like we might:

<kov>
 shiira implements the webViewShow delegate and does this:
     document = [[NSDocumentController sharedDocumentController] 
	     documentForWindow:[webView window]];
     [document showWindows];
 kalikiana: aha:
http://developer.apple.com/documentation/Cocoa/Conceptual/DisplayWebContent/Tas
ks/MultipleWindows.html#//apple_ref/doc/uid/20002026-117573
 kalikiana: that may answer our doubt about the delay; according to that doc,
show-web-view would be invoked directly after create-web-view
 what I find weird about the way this is documented is that their
createWebViewWithRequest needs to ask the frame to load the request, while, as
barisione showed me, webcore already loads the request on the newly created
webview

<kalikiana>
kov: Hm.... makes me wonder how useful that signal is. I mean, if web-view-show
is emitted immediately afterwards anyway, why bother to use that?